joooger commented on a change in pull request #8962:
URL: https://github.com/apache/ignite/pull/8962#discussion_r609726857
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/managers/indexing/IndexesRebuildTask.java
##########
@@ -103,30 +109,42 @@
}
}
- if (nonNull(err))
+ if (err != null)
U.error(log, "Failed to rebuild indexes for cache: " +
cacheName, err);
- outRebuildCacheIdxFut.onDone(err);
-
idxRebuildFuts.remove(cctx.cacheId(), intRebFut);
intRebFut.onDone(err);
+
+ outRebuildCacheIdxFut.onDone(err);
});
startRebuild(cctx, rebuildCacheIdxFut, clo, intRebFut.cancelToken());
return outRebuildCacheIdxFut;
}
- /** Actual start rebuilding. Use this method for test purposes only. */
- protected void startRebuild(GridCacheContext cctx, GridFutureAdapter<Void>
fut,
- SchemaIndexCacheVisitorClosure clo,
SchemaIndexOperationCancellationToken cancel) {
+ /**
+ * Actual start rebuilding. Use this method for test purposes only.
+ *
+ * @param cctx Cache context.
+ * @param fut rebuildIdxFut Future for rebuild indexes.
Review comment:
```suggestion
* @param fut Future for rebuild indexes.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
