vveider commented on a change in pull request #155:
URL: https://github.com/apache/ignite-3/pull/155#discussion_r642318851
##########
File path: parent/pom.xml
##########
@@ -467,6 +468,53 @@
</build>
</profile>
+ <!--
+ Profile that activates automatically when maven.test.skip is set
to true and excludes the test phase
Review comment:
Comment is a bit confusing, let's rephrase:
```
Profile to exclude the test phase from maven lifecycle when maven.test.skip
is set. It is required to mitigate the issue with test-scope dependencies in
non tested builds
```
No need for additional info about automatic activation (previous profile has
no such info too).
##########
File path: parent/pom.xml
##########
@@ -449,6 +449,7 @@
Profile to exclude running surefire (unit) tests but do not
prevent running integration ones
-->
<profile>
+ <id>skip-surefire</id>
Review comment:
Let's rename it as `skip-unit-tests` to comply with overall naming.
##########
File path: parent/pom.xml
##########
@@ -467,6 +468,53 @@
</build>
</profile>
+ <!--
+ Profile that activates automatically when maven.test.skip is set
to true and excludes the test phase
+ -->
+ <profile>
+ <id>skip-all-tests</id>
+ <activation>
+ <property>
+ <name>maven.test.skip</name>
+ <value>true</value>
Review comment:
Value is unnecessary, because with use `-Dmaven.test.skip` notation in
command line calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
