korlov42 commented on a change in pull request #9081: URL: https://github.com/apache/ignite/pull/9081#discussion_r682463592
########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/reducer/MergeSortDistributedCacheQueryReducer.java ########## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.cache.query.reducer; + +import java.lang.reflect.Array; +import java.util.Arrays; +import java.util.Collection; +import java.util.Comparator; +import java.util.Map; +import java.util.NoSuchElementException; +import java.util.UUID; +import java.util.concurrent.ConcurrentHashMap; +import org.apache.ignite.IgniteCheckedException; +import org.apache.ignite.cluster.ClusterNode; +import org.apache.ignite.internal.processors.cache.query.CacheQueryPageRequester; +import org.apache.ignite.internal.processors.cache.query.GridCacheQueryFutureAdapter; +import org.apache.ignite.internal.util.typedef.internal.U; + +/** + * Reducer of distirbuted query that sort result through all nodes. Note that it's assumed that every node + * returns pre-sorted collection of data. + */ +public class MergeSortDistributedCacheQueryReducer<R> extends AbstractDistributedCacheQueryReducer<R> { + /** Map of Node ID to stream. Used for inserting new pages. */ + private final Map<UUID, NodePageStream<R>> streamsMap; + + /** Array of streams. Used for iteration over result pages. */ + private final NodePageStream<R>[] streams; + + /** If {@code true} then there wasn't call {@link #hasNext()} on this reducer. */ + private boolean first = true; + + /** + * Offset of current stream to get next value. This offset only increments if a stream is done. The array {@link + * #streams} is sorted to put stream with lowest value on this offset. + */ + private int streamOff; + + /** Compares head of streams to get lowest value at the moment. */ + private final Comparator<NodePageStream<R>> streamCmp; + + /** + * @param fut Cache query future. + * @param reqId Cache query request ID. + * @param pageRequester Provides a functionality to request pages from remote nodes. + * @param queueLock Lock object that is shared between GridCacheQueryFuture and reducer. + * @param nodes Collection of nodes this query applies to. + * @param rowCmp Comparator to sort query results from different nodes. + */ + public MergeSortDistributedCacheQueryReducer( + GridCacheQueryFutureAdapter fut, long reqId, CacheQueryPageRequester pageRequester, + Object queueLock, Collection<ClusterNode> nodes, Comparator<R> rowCmp + ) { + super(fut, reqId, pageRequester); + + streamsMap = new ConcurrentHashMap<>(nodes.size()); + streams = (NodePageStream<R>[])Array.newInstance(NodePageStream.class, nodes.size()); + + int i = 0; + + for (ClusterNode node : nodes) { + streams[i] = new NodePageStream<>(fut.query().query(), queueLock, fut.endTime(), node.id(), (ns, all) -> + pageRequester.requestPages(reqId, fut, ns, all) Review comment: do we really need to create lambda for every node? ########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/reducer/UnsortedDistributedCacheQueryReducer.java ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.cache.query.reducer; + +import java.util.Collection; +import java.util.HashSet; +import java.util.UUID; +import org.apache.ignite.IgniteCheckedException; +import org.apache.ignite.cluster.ClusterNode; +import org.apache.ignite.internal.processors.cache.query.CacheQueryPageRequester; +import org.apache.ignite.internal.processors.cache.query.GridCacheQueryFutureAdapter; +import org.jetbrains.annotations.Nullable; + +/** + * Reducer of distributed query, fetch pages from remote nodes. All pages go in single page stream so no ordering is provided. + */ +public class UnsortedDistributedCacheQueryReducer<R> extends AbstractDistributedCacheQueryReducer<R> { + /** Single page stream. */ + private final PageStream<R> pageStream; + + /** + * @param fut Cache query future. + * @param reqId Cache query request ID. + * @param pageRequester Provides a functionality to request pages from remote nodes. + * @param queueLock Lock object that is shared between GridCacheQueryFuture and reducer. + * @param nodes Collection of nodes this query applies to. + */ + public UnsortedDistributedCacheQueryReducer( + GridCacheQueryFutureAdapter fut, long reqId, CacheQueryPageRequester pageRequester, + Object queueLock, Collection<ClusterNode> nodes) { + Review comment: empty line ########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/reducer/MergeSortDistributedCacheQueryReducer.java ########## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.cache.query.reducer; + +import java.lang.reflect.Array; +import java.util.Arrays; +import java.util.Collection; +import java.util.Comparator; +import java.util.Map; +import java.util.NoSuchElementException; +import java.util.UUID; +import java.util.concurrent.ConcurrentHashMap; +import org.apache.ignite.IgniteCheckedException; +import org.apache.ignite.cluster.ClusterNode; +import org.apache.ignite.internal.processors.cache.query.CacheQueryPageRequester; +import org.apache.ignite.internal.processors.cache.query.GridCacheQueryFutureAdapter; +import org.apache.ignite.internal.util.typedef.internal.U; + +/** + * Reducer of distirbuted query that sort result through all nodes. Note that it's assumed that every node + * returns pre-sorted collection of data. + */ +public class MergeSortDistributedCacheQueryReducer<R> extends AbstractDistributedCacheQueryReducer<R> { + /** Map of Node ID to stream. Used for inserting new pages. */ + private final Map<UUID, NodePageStream<R>> streamsMap; + + /** Array of streams. Used for iteration over result pages. */ + private final NodePageStream<R>[] streams; Review comment: array should be replaced with PriorityQueue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
