timoninmaxim commented on a change in pull request #9363:
URL: https://github.com/apache/ignite/pull/9363#discussion_r700065552
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/query/GridQueryProcessor.java
##########
@@ -1969,7 +1970,7 @@ else if (op instanceof SchemaAddQueryEntityOperation) {
}
if
(idxRebuildFutStorage.prepareRebuildIndexes(singleton(cacheInfo.cacheId()),
null).isEmpty())
- rebuildIndexesFromHash0(cacheInfo.cacheContext(), false);
+ rebuildIndexesFromHash0(cacheInfo.cacheContext(), false,
null);
Review comment:
Why null is set there? There is a `cancelTok` in the
`processSchemaOperationCancellationToken`.
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/query/schema/SchemaIndexOperationCancellationToken.java
##########
@@ -1,52 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.ignite.internal.processors.query.schema;
-
-import java.util.concurrent.atomic.AtomicBoolean;
-import org.apache.ignite.internal.util.typedef.internal.S;
-
-/**
- * Index operation cancellation token.
- */
-public class SchemaIndexOperationCancellationToken {
- /** Cancel flag. */
- private final AtomicBoolean flag = new AtomicBoolean();
Review comment:
I don't like the idea to replace this class with just AtomicReference.
It breaks the SRP OOP principle: now there are 2 separated interfaces for work
with cancellation (AtomicReference for set/get and Supplier<Throwable> for get)
instead of single class.
But I like the idea to replace AtomicBoolean with AtomicReference within
this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
