AMashenkov commented on a change in pull request #309:
URL: https://github.com/apache/ignite-3/pull/309#discussion_r703332380
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/ddl/CreateTableCommand.java
##########
@@ -19,76 +19,33 @@
import java.util.List;
+import org.apache.ignite.schema.Column;
import org.jetbrains.annotations.Nullable;
/**
* CREATE TABLE statement.
*/
-public class CreateTableCommand implements DdlCommand {
+public class CreateTableCommand extends DdlCommand {
/**
* Schema name upon which this statement has been issued - <b>not</b> the
name of the schema where this new table
* will be created.
*/
private String schemaName;
- /** Table name. */
- private String tblName;
-
- /** Cache name upon which new cache configuration for this table must be
based. */
- private String templateName;
-
/** Name of new cache associated with this table. */
private String cacheName;
Review comment:
Let's rename to tableName or even reuse from parent class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
