timoninmaxim commented on a change in pull request #9429:
URL: https://github.com/apache/ignite/pull/9429#discussion_r722594095



##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/cache/query/index/sorted/IndexRowComparator.java
##########
@@ -43,4 +43,12 @@
      * @param idx offset of index key.
      */
     public int compareKey(IndexRow left, IndexRow right, int idx) throws 
IgniteCheckedException;
+
+    /**
+     * Compare index keys.
+     *
+     * @param left index key.
+     * @param right index key.
+     */
+    public int compareSearchKey(IndexKey left, IndexKey right) throws 
IgniteCheckedException;

Review comment:
       > I see we duplicate the following and wish this can be fixed
   
   It's duplicated because we put all logic of comparison related to H2 to 
single place. Actually there is no much of duplicated code there. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to