zstan commented on a change in pull request #9476:
URL: https://github.com/apache/ignite/pull/9476#discussion_r723926084
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/ExecutionServiceImpl.java
##########
@@ -828,16 +618,15 @@ private FieldsMetadata
queryFieldsMetadata(PlanningContext ctx, RelDataType sqlT
return new FieldsMetadataImpl(resultType, origins);
}
- /** */
- private boolean single(SqlNode sqlNode) {
- return !(sqlNode instanceof SqlNodeList);
- }
-
/** */
private void onMessage(UUID nodeId, final QueryStartRequest msg) {
assert nodeId != null && msg != null;
try {
+ Query<Row> qryNew = new Query<>(msg.queryId(), null, (q) ->
qryReg.unregister(q.id()));
+
+ Query<Row> qry = qryReg.register(qryNew);
Review comment:
contract of register method shows that it can return query by uuid if
such a query already registered, in such a case we can potentially obtain a
problems here, do we need such contract ? I found that return state of register
is used only here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
