kgusakov commented on a change in pull request #379: URL: https://github.com/apache/ignite-3/pull/379#discussion_r724407568
########## File path: modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ITBaselineChangesTest.java ########## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.runner.app; + +import java.nio.file.Path; +import java.util.ArrayList; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; +import java.util.Set; +import com.google.common.collect.Lists; +import org.apache.ignite.Ignite; +import org.apache.ignite.IgnitionManager; +import org.apache.ignite.internal.schema.configuration.SchemaConfigurationConverter; +import org.apache.ignite.internal.testframework.WorkDirectory; +import org.apache.ignite.internal.testframework.WorkDirectoryExtension; +import org.apache.ignite.internal.util.IgniteUtils; +import org.apache.ignite.schema.SchemaBuilders; +import org.apache.ignite.schema.definition.ColumnType; +import org.apache.ignite.schema.definition.TableDefinition; +import org.apache.ignite.table.RecordView; +import org.apache.ignite.table.Table; +import org.apache.ignite.table.Tuple; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.TestInfo; +import org.junit.jupiter.api.extension.ExtendWith; + +import static org.apache.ignite.internal.testframework.IgniteTestUtils.testNodeName; +import static org.junit.jupiter.api.Assertions.assertEquals; + +/** + * Test for baseline changes + */ +@ExtendWith(WorkDirectoryExtension.class) +public class ITBaselineChangesTest { + /** Start network port for test nodes. */ + private static final int BASE_PORT = 3344; + + /** Nodes bootstrap configuration. */ + private final Map<String, String> initClusterNodes = new LinkedHashMap<>(); + + /** */ + private final List<Ignite> clusterNodes = new ArrayList<>(); + + /** */ + @WorkDirectory + private Path workDir; + + /** */ + @BeforeEach + void setUp(TestInfo testInfo) { + String node0Name = testNodeName(testInfo, BASE_PORT); + String node1Name = testNodeName(testInfo, BASE_PORT + 1); + String node2Name = testNodeName(testInfo, BASE_PORT + 2); + + initClusterNodes.put( + node0Name, + buildConfig(node0Name, 0) + ); + + initClusterNodes.put( + node1Name, + buildConfig(node0Name, 1) + ); + + initClusterNodes.put( + node2Name, + buildConfig(node0Name, 2) + ); + } + + /** */ + @AfterEach + void tearDown() throws Exception { + IgniteUtils.closeAll(Lists.reverse(clusterNodes)); + } + + /** + * Check dynamic table creation. + */ + @Test + void testBaselineExtending(TestInfo testInfo) { + initClusterNodes.forEach((nodeName, configStr) -> + clusterNodes.add(IgnitionManager.start(nodeName, configStr, workDir.resolve(nodeName))) + ); + + assertEquals(3, clusterNodes.size()); + + // Create table on node 0. + TableDefinition schTbl1 = SchemaBuilders.tableBuilder("PUBLIC", "tbl1").columns( + SchemaBuilders.column("key", ColumnType.INT64).asNonNull().build(), + SchemaBuilders.column("val", ColumnType.INT32).asNullable().build() + ).withPrimaryKey("key").build(); + + clusterNodes.get(0).tables().createTable(schTbl1.canonicalName(), tblCh -> + SchemaConfigurationConverter.convert(schTbl1, tblCh) + .changeReplicas(5) + .changePartitions(1) + ); + + // Put data on node 1. + Table tbl1 = clusterNodes.get(1).tables().table(schTbl1.canonicalName()); + RecordView<Tuple> recView1 = tbl1.recordView(); + + recView1.insert(Tuple.create().set("key", 1L).set("val", 111)); + + // Get data on node 2. + Table tbl2 = clusterNodes.get(2).tables().table(schTbl1.canonicalName()); + RecordView<Tuple> recView2 = tbl2.recordView(); + + final Tuple keyTuple1 = Tuple.create().set("key", 1L); + + assertEquals(1, (Long)recView2.get(keyTuple1).value("key")); + + var metaStoreNode = clusterNodes.get(0); + + var node3Name = testNodeName(testInfo, nodePort(3)); + var node4Name = testNodeName(testInfo, nodePort(4)); + + // Start 2 new nodes after + var node3 = IgnitionManager.start( + node3Name, buildConfig(metaStoreNode.name(), 3), workDir.resolve(node3Name)); + var node4 = IgnitionManager.start( + node4Name, buildConfig(metaStoreNode.name(), 4), workDir.resolve(node4Name)); + + clusterNodes.add(node3); + clusterNodes.add(node4); + + // Update baseline to nodes 1,4,5 + metaStoreNode.setBaseline(Set.of(metaStoreNode.name(), node3Name, node4Name)); + + IgnitionManager.stop(clusterNodes.get(1).name()); + IgnitionManager.stop(clusterNodes.get(2).name()); + + Table tbl4 = node4.tables().table(schTbl1.canonicalName()); + + assertEquals(1, (Long) tbl4.recordView().get(keyTuple1).value("key")); Review comment: If it didn't see reassignment - it means, that the raft node for the table group is not started yet too (it starts inside assignment listener) - it means, that changePeers must fail above. But anyway - we have small gap between starting raft node and updating -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
