timoninmaxim commented on a change in pull request #9081:
URL: https://github.com/apache/ignite/pull/9081#discussion_r725853902
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryFutureAdapter.java
##########
@@ -143,43 +126,62 @@ public GridCacheQueryBean query() {
return qry;
}
+ /** {@inheritDoc} */
+ @Override public IgniteLogger logger() {
+ return log;
+ }
+
/**
* @return If fields query.
*/
- boolean fields() {
+ public boolean fields() {
return false;
}
- /** {@inheritDoc} */
- @Override public boolean onDone(Collection<R> res, Throwable err) {
- cctx.time().removeTimeoutObject(this);
-
- return super.onDone(res, err);
- }
-
/** {@inheritDoc} */
@Override public R next() {
try {
- R next = unmaskNull(internalIterator().next());
+ if (!limitDisabled && cnt == capacity)
+ return null;
+
+ checkError();
+
+ R next = null;
- cnt.decrementAndGet();
+ if (reducer.hasNext()) {
+ next = unmaskNull(reducer.next());
+
+ if (!limitDisabled) {
+ cnt++;
+
+ // Exceed limit, stop page loading and cancel queries.
+ if (cnt == capacity)
+ cancel();
+ }
+ }
+
+ checkError();
Review comment:
In case of error we have in `checkError()` all page streams are already
closed, as they have `cancel()` method that invokes automatically when future
failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
