ygerzhedovich commented on a change in pull request #401:
URL: https://github.com/apache/ignite-3/pull/401#discussion_r730915003
##########
File path:
modules/schema/src/main/java/org/apache/ignite/internal/schema/definition/TableDefinitionImpl.java
##########
@@ -101,18 +82,18 @@ public TableDefinitionImpl(
}
/** {@inheritDoc} */
- @Override public Collection<ColumnDefinition> keyColumns() {
+ @Override public Set<String> keyColumns() {
return keyCols;
}
/** {@inheritDoc} */
- @Override public Collection<ColumnDefinition> affinityColumns() {
+ @Override public Set<String> affinityColumns() {
return affCols;
}
/** {@inheritDoc} */
- @Override public Collection<ColumnDefinition> valueColumns() {
- return valCols;
+ @Override public Collection<ColumnDefinition> columns() {
Review comment:
seems to need to mention about the order in TableDefinition interface
javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
