ibessonov commented on a change in pull request #402:
URL: https://github.com/apache/ignite-3/pull/402#discussion_r731790126
##########
File path:
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/TableStorage.java
##########
@@ -25,12 +26,47 @@
*/
public interface TableStorage {
/**
- * Gets or creates a partition for current table.
+ * Retrieves or creates a partition for current table. Not expected to be
called concurrently with the same
+ * partition id.
*
* @param partId Partition id.
* @return Partition storage.
+ * @throws IllegalArgumentException If partition id is invalid.
+ * @throws StorageException If error occurred during partition creation.
*/
- PartitionStorage getOrCreatePartition(int partId);
+ PartitionStorage getOrCreatePartition(int partId) throws StorageException;
+
+ /**
+ * Returns partition storage or {@code null} if required storage doesn't
exist.
+ *
+ * @param partId Partition id.
+ * @return Partition storage or {@code null}.
+ * @throws IllegalArgumentException If partition id is invalid.
Review comment:
I'll rephrase that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
