isapego commented on a change in pull request #9517:
URL: https://github.com/apache/ignite/pull/9517#discussion_r735583216
##########
File path: modules/platforms/cpp/CMakeSettings.json.in
##########
@@ -0,0 +1,64 @@
+{
+ "environments": [
+ {
+ "JAVA_HOME": "<PATH_TO_JDK>",
+ "BOOST_ROOT": "<PATH_TO_BOOST",
+ "OPENSSL_ROOT_DIR": "<PATH_TO_OPENSSL>",
+ "BuildDir":
"${env.USERPROFILE}\\CMakeBuilds\\ignite-cpp\\${workspaceHash}",
+ "InstallDir": "<INSTALL_DIR>"
+ }
+ ],
+
+ "configurations": [
+ {
+ "name": "x64-Debug",
+ "generator": "Visual Studio 15 2017 Win64",
+ "configurationType": "Debug",
+ "inheritEnvironments": [ "msvc_x64" ],
+ "buildRoot": "${env.BuildDir}}\\cmake-build-debug",
+ "variables": [
+ {
+ "name": "CMAKE_INSTALL_PREFIX",
+ "value": "${env.InstallDir}\\debug"
+ },
+ {
+ "name": "WITH_ODBC",
+ "value": "ON"
+ },
+ {
+ "name": "WITH_THIN_CLIENT",
+ "value": "ON"
+ },
+ {
+ "name": "WITH_TESTS",
+ "value": "ON"
Review comment:
I believe tests should be disabled by default. We do not even include
them in binary package.
##########
File path: modules/platforms/cpp/DEVNOTES.txt
##########
@@ -1,47 +1,68 @@
Apache Ignite C++ Build Instructions
====================================
-Here you can find instruction on how to build Apache Ignite C++ core library
and
-stand-alone node binary. To build examples you need to build and install core
Apache
-Ignite library then refer to $IGNITE_HOME/platforms/cpp/example/README.txt for
+Here you can find instruction on how to build Apache Ignite C++.
+In order to build examples you need to build and install Apache Ignite C++
+libraries then refer to $IGNITE_HOME/platforms/cpp/example/README.txt for
further instructions.
For details on ODBC driver installation and usage please refer to
$IGNITE_HOME/platforms/cpp/odbc/README.txt.
-Building on Linux and Mac OS X with CMake (Windows currently not yet supported)
-----------------------------------
-
Common Requirements:
-
- * GCC, g++, CMake >= 3.6 must be installed
+ * C++ compiler and SDK:
+ Linux and Mac OS X:
+ * clang 3.9 or later
+ * gcc 3.6 or later
Review comment:
We should mention that either of these is enough, we do not need both.
##########
File path: modules/platforms/cpp/CMakeSettings.json.in
##########
@@ -0,0 +1,64 @@
+{
+ "environments": [
+ {
+ "JAVA_HOME": "<PATH_TO_JDK>",
+ "BOOST_ROOT": "<PATH_TO_BOOST",
+ "OPENSSL_ROOT_DIR": "<PATH_TO_OPENSSL>",
Review comment:
Why don't use env variables by default? At least `JAVA_HOME` and
`BOOST_ROOT` are pretty common.
##########
File path: modules/platforms/cpp/DEVNOTES.txt
##########
@@ -1,47 +1,68 @@
Apache Ignite C++ Build Instructions
====================================
-Here you can find instruction on how to build Apache Ignite C++ core library
and
-stand-alone node binary. To build examples you need to build and install core
Apache
-Ignite library then refer to $IGNITE_HOME/platforms/cpp/example/README.txt for
+Here you can find instruction on how to build Apache Ignite C++.
+In order to build examples you need to build and install Apache Ignite C++
+libraries then refer to $IGNITE_HOME/platforms/cpp/example/README.txt for
further instructions.
For details on ODBC driver installation and usage please refer to
$IGNITE_HOME/platforms/cpp/odbc/README.txt.
-Building on Linux and Mac OS X with CMake (Windows currently not yet supported)
-----------------------------------
-
Common Requirements:
-
- * GCC, g++, CMake >= 3.6 must be installed
+ * C++ compiler and SDK:
+ Linux and Mac OS X:
+ * clang 3.9 or later
+ * gcc 3.6 or later
+ Windows:
+ * Visual Studio 2010 or later
Review comment:
Can we generate project for VS 2010?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
