tledkov-gridgain commented on a change in pull request #9476:
URL: https://github.com/apache/ignite/pull/9476#discussion_r737569515
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/ExecutionServiceImpl.java
##########
@@ -828,16 +622,13 @@ private FieldsMetadata
queryFieldsMetadata(PlanningContext ctx, RelDataType sqlT
return new FieldsMetadataImpl(resultType, origins);
}
- /** */
- private boolean single(SqlNode sqlNode) {
- return !(sqlNode instanceof SqlNodeList);
- }
-
/** */
private void onMessage(UUID nodeId, final QueryStartRequest msg) {
assert nodeId != null && msg != null;
try {
+ Query<Row> qry = qryReg.register(new Query<>(msg.queryId(), null,
(q) -> qryReg.unregister(q.id())));
Review comment:
Not catch an idea.
Do you suggest the one additional lookup in the map?
```
qry = qryReg.query(msg.queryId())?
if (qry == null) {
qry = qryReg.register(new Query()); // computeIfAbsent is replaced to
putIfAbsent inside.
}
```
Please take a look at the @korlov42
[comment](https://github.com/apache/ignite/pull/9476#discussion_r735693816).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
