sanpwc commented on a change in pull request #400:
URL: https://github.com/apache/ignite-3/pull/400#discussion_r738403210
##########
File path:
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/command/DeleteAllCommand.java
##########
@@ -37,16 +38,21 @@
*/
private byte[] rowsBytes;
+ /** The timestamp. */
+ private final Timestamp timestamp;
Review comment:
Not sure that it's a good idea to mix transaction specific logic to raft
command, however if it's the only option why not to extend abstract
TXRaftCommand that will own timestamp field instead of duplicating it in
multiple raft commands?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
