AMashenkov commented on a change in pull request #408:
URL: https://github.com/apache/ignite-3/pull/408#discussion_r740181595
##########
File path:
modules/table/src/test/java/org/apache/ignite/internal/table/RecordBinaryViewOperationsTest.java
##########
@@ -410,4 +413,17 @@ void assertEqualsValues(SchemaDescriptor schema, Tuple
expected, Tuple actual) {
@NotNull private TableImpl createTableImpl(SchemaDescriptor schema) {
return new TableImpl(new DummyInternalTableImpl(), new
DummySchemaManagerImpl(schema), null);
}
+
+ public <T extends Throwable> void assertThrowsWithCause(Class<T>
expectedType, Executable executable) {
Review comment:
I think we should check a public exception here and error code, once we
will introduce codes and public exceptions.
So, an assertThrowsWithCause must be replaced to junit assertThrows with a
correct public exception.
We check a cause here, which is an internal exception, as a temporal
solution unless we have public classes and error codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
