tledkov-gridgain commented on a change in pull request #416:
URL: https://github.com/apache/ignite-3/pull/416#discussion_r740188761
##########
File path:
modules/schema/src/main/java/org/apache/ignite/internal/schema/marshaller/Serializer.java
##########
@@ -28,33 +31,38 @@
*
* @param key Key object.
* @param val Value object.
- * @return Serialized key-value pair.
+ * @return Binary row.
* @throws SerializationException If serialization failed.
*/
- byte[] serialize(Object key, Object val) throws SerializationException;
+ BinaryRow serialize(Object key, Object val) throws SerializationException;
/**
- * @param data Key bytes.
+ * @param row Row.
* @param <K> Key object type.
* @return Key object.
* @throws SerializationException If deserialization failed.
*/
- <K> K deserializeKey(byte[] data) throws SerializationException;
+ <K> K deserializeKey(Row row) throws SerializationException;
/**
- * @param data Value bytes.
+ * @param row Row.
* @param <V> Value object type.
* @return Value object.
* @throws SerializationException If deserialization failed.
*/
- <V> V deserializeValue(byte[] data) throws SerializationException;
+ <V> V deserializeValue(Row row) throws SerializationException;
/**
- * @param data Row bytes.
+ * @param row Row.
* @param <K> Key object type.
* @param <V> Value object type.
* @return Key-value pair.
* @throws SerializationException If deserialization failed.
*/
- <K, V> Pair<K,V> deserialize(byte[] data) throws SerializationException;
+ <K, V> Pair<K,V> deserialize(Row row) throws SerializationException;
Review comment:
Please add the space between generic parameters:
<K, V> Pair<K,_V>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
