rpuch commented on pull request #9554: URL: https://github.com/apache/ignite/pull/9554#issuecomment-970192040
@vveider thank you for the advice, I will contact Nikita. ### About special paragraph As for Maven Wrapper specific prerequisites: according to https://github.com/takari/maven-wrapper , they should run on JDK 7, while Ignite requires JDK 8 itself, so no problem here. Also, they seem to support any decent `sh` flavour (I mean, Unix-like shells). Apart from this, Maven Wrapper requires Java 8 and `JAVA_HOME` variable set, but this is exactly what is needed for vanilla Maven, so nothing new here. So it seems that we simply do not need to mention anything specific about Maven Wrapper prerequisites: it will just work everywhere where Maven would work. Its usage is also straightforward: you just say `./mvnw` instead of `mvn`, and it transparently works in the same way as for `mvn`, but handles Maven management itself. Given all this, are you sure that we need to have that special paragraph in DEVNOTES? ### About `./mvnw` spell As for `./mvnw` on different systems, there are two groups. * Unix-like systems (Linux, Mac OS, etc): it works in sh, bash, dash, zsh, so basically 'everywhere' * Windows. Here we have a zoo! I carried out a quick poll in our Slack channel about Windows users preferences. They named PowerShell, cmd, Idea builtin shell, cygwin, git-bash, WSL (Windows Subsystem for Linux). - In PowerShell (Win10), `./mvnw`, `.\mvnw`, `./mvnw.cmd`, `.\mvnw.cmd` all work, but `mvnw` and `mvnw.cmd` do not work with default settings - In cmd (Win10), only `.\mvnw` and `.\mvnw.cmd` work, while `mvnw` and `mvnw.cmd` still do not work with default settings - In the Maven Wrapper documentation https://github.com/takari/maven-wrapper , they mention `mvnw.cmd` spell to invoke it on Windows. This does not seem to work on modern Windows versions, but it probably did in earlier ones. But they also say `mvn` where it clearly should be `./mvnw`, so there is a probability of a mistake in their documentation... - In Idea, the built-in shell seems to default to the system default (in my case, it was PowerShell) - cygwin, git-bash, WSL all have `bash` in them, so `./mvnw` works With all this, it looks like `./mvnw` should work for *nearly* everyone, but not for all. I could add a paragraph in the beginning of DEVNOTES about this discrepancy, like 'For most users on Unix-like systems and in PowerShell, `./mvnw` will work, so we use `./mvnw` spell everywhere in the docs, but if you use `cmd`, write `\.mvnw`'. Would this be enough? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
