zstan commented on a change in pull request #520:
URL: https://github.com/apache/ignite-3/pull/520#discussion_r776648018



##########
File path: 
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/SqlSchemaManagerImpl.java
##########
@@ -64,6 +76,30 @@ public SchemaPlus schema(@Nullable String schema) {
         return schema != null ? calciteSchema.getSubSchema(schema) : 
calciteSchema;
     }
 
+    /** {@inheritDoc} */
+    @Override
+    @NotNull
+    public InternalIgniteTable tableById(IgniteUuid id) {
+        ensureTableUpToDate(id);
+
+        InternalIgniteTable table = tablesById.get(id);

Review comment:
       can we swap:
   1.  InternalIgniteTable table = tablesById.get(id);
   2. if (table == null) {
   ensureTableUpToDate(id);
   table = tablesById.get(id);
   }
   
   something like that ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to