anton-vinogradov commented on a change in pull request #9661:
URL: https://github.com/apache/ignite/pull/9661#discussion_r782913455
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java
##########
@@ -699,12 +701,12 @@ public void onKernalStop() {
/*skip values*/true,
false);
- boolean readRepair = opCtx != null && opCtx.readRepair();
+ ReadRepairStrategy readRepairStrategy = opCtx != null ?
opCtx.readRepairStrategy() : null;
- if (readRepair)
+ if (readRepairStrategy != null)
return getWithRepairAsync(
fut,
- () -> repairAsync(key, opCtx, true),
+ (ks) -> repairAsync(ks, opCtx, true),
Review comment:
1) This will increase code complexity.
The same way should be used everywhere.
2) Now we use keys from `IgniteConsistencyViolationException` where keys are
`KeyCacheObject's`, while `K key` can be any plain object (that's not a problem
now, but can lead to problems in the future).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
