tkalkirill commented on a change in pull request #754:
URL: https://github.com/apache/ignite-3/pull/754#discussion_r840666035
##########
File path:
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/StorageEngine.java
##########
@@ -27,32 +26,31 @@
*/
public interface StorageEngine {
/**
- * Starts the engine.
+ * Returns the unique name of the storage engine.
+ *
+ * <p>NOTE: Used to map {@link DataStorageConfigurationSchema#name} to
{@link StorageEngine#name}.
Review comment:
Fix it.
##########
File path:
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PageMemoryDataRegion.java
##########
@@ -48,7 +47,7 @@ public PageMemoryDataRegion(PageMemoryDataRegionConfiguration
cfg, PageIoRegistr
/** {@inheritDoc} */
@Override
- public void stop() {
+ public void stop() throws Exception {
Review comment:
No, fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
