anton-vinogradov commented on code in PR #9471:
URL: https://github.com/apache/ignite/pull/9471#discussion_r847555176
##########
modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryUtils.java:
##########
@@ -153,6 +170,9 @@ public class BinaryUtils {
/** FNV1 hash prime. */
private static final int FNV1_PRIME = 0x01000193;
+ /** File lock timeout in milliseconds. */
+ private static final int FILE_LOCK_TIMEOUT_MS = 5000;
Review Comment:
Has no usages.
##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/TypeMappingImpl.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.cdc;
+
+import org.apache.ignite.cdc.TypeMapping;
+import org.apache.ignite.internal.util.typedef.internal.S;
+import org.apache.ignite.platform.PlatformType;
+
+/** */
+public class TypeMappingImpl implements TypeMapping {
+ /** Serial version uid. */
+ private static final long serialVersionUID = 0L;
+
+ /** */
+ private final int typeId;
+
+ /** */
+ private final String typeName;
+
+ /** */
+ private final PlatformType platform;
+
+ /**
+ * @param typeId Type id.
+ * @param typeName Type name.
+ * @param platform Platform.
+ */
+ public TypeMappingImpl(int typeId, String typeName, PlatformType platform)
{
+ this.typeId = typeId;
+ this.typeName = typeName;
+ this.platform = platform;
+ }
+
+ /** {@inheritDoc} */
+ @Override public int typeId() {
+ return typeId;
+ }
+
+ /** {@inheritDoc} */
+ @Override public String typeName() {
+ return typeName;
+ }
+
+ /** {@inheritDoc} */
+ @Override public PlatformType platform() {
Review Comment:
platformType?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/binary/CacheObjectBinaryProcessorImpl.java:
##########
@@ -1061,6 +1065,19 @@ public BinaryMetadata binaryMetadata(int typeId) throws
BinaryObjectException {
}
}
+ /** {@inheritDoc} */
+ @Override public void cacheMetadataLocally(File metadataDir, int typeId)
throws IgniteCheckedException {
+ if (!metadataDir.exists())
+ return;
+
+ ConcurrentMap<Integer, BinaryMetadataHolder> metaCache = new
ConcurrentHashMap<>();
+
+ new BinaryMetadataFileStore(metaCache, ctx, log, metadataDir)
+ .restoreMetadata(typeId);
Review Comment:
no newline needed
##########
modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryUtils.java:
##########
@@ -2526,6 +2546,83 @@ public static BinaryType type(BinaryContext ctx,
BinaryObjectEx obj) {
return ctx.metadata(obj.typeId());
}
+ /**
+ * @param typeId Type id.
+ * @return Binary metadata file name.
+ */
+ public static String binaryMetaFileName(int typeId) {
+ return typeId + METADATA_FILE_SUFFIX;
+ }
+
+ /** @param fileName Name of file with marshaller mapping information. */
+ public static int mappedTypeId(String fileName) {
+ try {
+ return Integer.parseInt(fileName.substring(0,
fileName.indexOf(MAPPING_FILE_EXTENSION)));
+ }
+ catch (NumberFormatException e) {
+ throw new IgniteException("Reading marshaller mapping from file "
+ + fileName
+ + " failed; type ID is expected to be numeric.", e);
+ }
+ }
+
+ /** @param fileName Name of file with marshaller mapping information. */
+ public static byte mappedFilePlatformId(String fileName) {
+ try {
+ return Byte.parseByte(fileName.substring(fileName.length() - 1));
Review Comment:
`fileName.length() - 1` duplicated at other methods, could we deduplicate
this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
