liyuj commented on PR #9983: URL: https://github.com/apache/ignite/pull/9983#issuecomment-1100972514
Thanks for your review, all your suggestions have been fixed. 在 2022/4/17 23:57, Nikita Amelchev 写道: > > ***@***.**** commented on this pull request. > > ------------------------------------------------------------------------ > > In > modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/evict/Random2LruPageEvictionTracker.java > <https://github.com/apache/ignite/pull/9983#discussion_r851774318>: > > > @@ -69,7 +69,7 @@ public Random2LruPageEvictionTracker( > > /** ***@***.***} */ > @Override public void start() throws IgniteException { > - trackingArrPtr = GridUnsafe.allocateMemory(trackingSize * 8); > + trackingArrPtr = GridUnsafe.allocateMemory((long)trackingSize * 8); > > A long constant can be used instead of casting for better readability: > |8L|, |4L| > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/ignite/pull/9983#pullrequestreview-943963281>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACGRBATG7Z4KFLP2RQUTLPDVFQYGFANCNFSM5TTEREJQ>. > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
