tkalkirill commented on code in PR #812:
URL: https://github.com/apache/ignite-3/pull/812#discussion_r881490001
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/impl/PageMemoryNoStoreImpl.java:
##########
@@ -170,18 +170,19 @@ public class PageMemoryNoStoreImpl implements PageMemory {
* @param directMemoryProvider Memory allocator to use.
* @param dataRegionCfg Data region configuration.
* @param ioRegistry IO registry.
+ * @param pageSize Page size in bytes.
*/
public PageMemoryNoStoreImpl(
DirectMemoryProvider directMemoryProvider,
- PageMemoryDataRegionConfiguration dataRegionCfg,
- PageIoRegistry ioRegistry
+ VolatilePageMemoryDataRegionConfiguration dataRegionCfg,
+ PageIoRegistry ioRegistry,
+ // TODO: IGNITE-17017 Move to common config
+ int pageSize
) {
this.directMemoryProvider = directMemoryProvider;
this.ioRegistry = ioRegistry;
this.trackAcquiredPages = false;
- this.dataRegionCfg = dataRegionCfg.value();
-
- int pageSize = this.dataRegionCfg.pageSize();
+ this.dataRegionCfg = (VolatilePageMemoryDataRegionView)
dataRegionCfg.value();
Review Comment:
Fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
