ygerzhedovich commented on code in PR #933:
URL: https://github.com/apache/ignite-3/pull/933#discussion_r916893531
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/RebalanceRaftGroupEventsListener.java:
##########
@@ -274,36 +273,36 @@ private void
doOnNewPeersConfigurationApplied(List<PeerId> peers) {
remove(plannedPartAssignmentsKey(partId)))
.yield(true),
ops().yield(false))).get().getAsBoolean()) {
- LOG.info("Planned key={} was changed, while trying to
update rebalance information about partition={}, table={} "
- + "to peers={}, another attempt will be made",
+ LOG.info("Planned key changed while trying to update
rebalance information. Going to retry"
+ + " [key={}, partition={}, table={},
appliedPeers={}]",
plannedPartAssignmentsKey(partId), partNum,
tblConfiguration.name(), appliedPeers);
doOnNewPeersConfigurationApplied(peers);
}
- LOG.info("Finished rebalance of partition={}, table={} to
peers={} and queued new rebalance to peers={}",
+ LOG.info("Rebalance finished. Going to schedule next rebalance
[partition={}, table={}, appliedPeers={}, plannedPeers={}]",
partNum, tblConfiguration.name().value(),
appliedPeers, ByteUtils.fromBytes(plannedEntry.value()));
} else {
if (!metaStorageMgr.invoke(If.iif(
notExists(plannedPartAssignmentsKey(partId)),
ops(put(stablePartAssignmentsKey(partId),
ByteUtils.toBytes(appliedPeers)),
remove(pendingPartAssignmentsKey(partId))).yield(true),
ops().yield(false))).get().getAsBoolean()) {
- LOG.info("Planned key={} was changed, while trying to
update rebalance information about partition={}, table={} "
- + "to peers={}, another attempt will be
made",
+ LOG.info("Planned key changed while trying to update
rebalance information. Going to retry"
+ + " [key={}, partition={}, table={},
appliedPeers={}]",
plannedPartAssignmentsKey(partId), partNum,
tblConfiguration.name(), appliedPeers);
doOnNewPeersConfigurationApplied(peers);
}
- LOG.info("Finished rebalance of partition={}, table={} to
peers={} and no new rebalance in planned key={} discovered",
- partNum, tblConfiguration.name().value(),
appliedPeers, plannedPartAssignmentsKey(partId));
+ LOG.info("Rebalance finished [partition={}, table={},
appliedPeers={}, plannedPeers={}]",
+ partNum, tblConfiguration.name().value(),
appliedPeers);
Review Comment:
absent 4th parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
