zstan commented on code in PR #10157:
URL: https://github.com/apache/ignite/pull/10157#discussion_r941329398
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/affinity/LocalAffinityFunction.java:
##########
@@ -27,7 +27,7 @@
import org.apache.ignite.cluster.ClusterNode;
/**
- * Affinity function for {@link org.apache.ignite.cache.CacheMode#LOCAL}
caches.
+ * Affinity function for {@code org.apache.ignite.cache.CacheMode#LOCAL}
caches.
Review Comment:
why do we need it ?
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/CacheStopAndDestroySelfTest.java:
##########
@@ -181,20 +177,6 @@ private CacheConfiguration getNearConfig() {
return cfg;
}
- /**
Review Comment:
upper code :
/** Local cache name. */
private static String CACHE_NAME_LOC = "cache_local";
Seems not used, remove it plz
##########
modules/clients/src/test/java/org/apache/ignite/internal/client/integration/ClientAbstractMultiNodeSelfTest.java:
##########
@@ -198,18 +196,13 @@ private CacheConfiguration cacheConfiguration(@NotNull
String cacheName) throws
cfg.setAtomicityMode(TRANSACTIONAL);
- switch (cacheName) {
- case DEFAULT_CACHE_NAME:
- cfg.setCacheMode(LOCAL);
- break;
- case PARTITIONED_CACHE_NAME:
- cfg.setCacheMode(PARTITIONED);
-
- cfg.setBackups(0);
- break;
- default:
- cfg.setCacheMode(REPLICATED);
- break;
+ if (PARTITIONED_CACHE_NAME.equals(cacheName)) {
Review Comment:
you can remove
c.setCacheConfiguration(cacheConfiguration(DEFAULT_CACHE_NAME), no need for
this configuration at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
