PakhomovAlexander commented on code in PR #1001:
URL: https://github.com/apache/ignite-3/pull/1001#discussion_r944820904
##########
modules/cli/src/main/java/org/apache/ignite/cli/call/cliconfig/profile/CliConfigProfileCreateCallInput.java:
##########
@@ -50,35 +53,4 @@ public String getCopyFrom() {
public boolean isActivate() {
return activate;
}
-
- /**
- * Builder of {@link CliConfigCreateProfileCallInput}.
- */
- public static class CliConfigCreateProfileCallInputBuilder {
Review Comment:
I am quite confused with the fact that you removed the builder only for this
input? Why dont remove all builders for CallInput? I think it is ok no to have
a builder for the input that has only one field but if the class has more that
one field it is quite useful to hava a builder. Bulder helps not to confuse
parameter names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
