tledkov commented on code in PR #10195:
URL: https://github.com/apache/ignite/pull/10195#discussion_r945578546
##########
modules/core/src/main/java/org/apache/ignite/internal/cache/query/index/IndexQueryProcessor.java:
##########
@@ -538,25 +442,12 @@ private boolean inclBoundary(IndexRangeQuery qry, boolean
lower) {
return true;
}
- /**
- * @param isNull {@code true} if user explicitly set {@code null} with a
query argument.
- */
- private IndexKey key(Object val, boolean isNull, IndexKeyDefinition def,
IndexKeyTypeSettings settings, CacheObjectContext coctx) {
- IndexKey key = null;
- IndexKeyType keyType = val == null ? IndexKeyType.NULL :
IndexKeyType.forClass(val.getClass());
-
- if (val != null || isNull)
- key = IndexKeyFactory.wrap(val, keyType, coctx, settings);
-
- return key;
- }
-
/**
* Checks index rows for matching to specified index criteria.
*/
private static class IndexQueryCriteriaClosure implements
BPlusTree.TreeRowClosure<IndexRow, IndexRow> {
Review Comment:
Maybe we should move inner classes to the top level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
