rpuch commented on code in PR #1120:
URL: https://github.com/apache/ignite-3/pull/1120#discussion_r980040931
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java:
##########
@@ -526,17 +526,10 @@ private TopologyEventHandler
cmgLeaderTopologyEventHandler(CmgRaftService raftSe
return new TopologyEventHandler() {
@Override
public void onAppeared(ClusterNode member) {
- raftService.readClusterState()
- .thenAccept(state -> {
- if (state != null) {
- sendClusterState(state, member)
- .whenComplete((v, e) -> {
- if (e != null) {
Review Comment:
`sendClusterState()` might throw something that is not covered by the code
on line 593 (like an exception when creating a message). This is currently
highly unlikely, but saw such cases in other projects (when due to a stupid
coding error an NPE is thrown, for instance). If such an un unforseen exception
is thrown, we will still not see it, and it will be pretty difficult to figure
out what's going on.
IMO, better safe than sorry :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
