rpuch commented on code in PR #1170:
URL: https://github.com/apache/ignite-3/pull/1170#discussion_r989984372
##########
modules/cluster-management/src/test/java/org/apache/ignite/internal/cluster/management/raft/AbstractClusterStateStorageTest.java:
##########
@@ -110,6 +110,50 @@ void testPutReplace() {
assertThat(storage.get(key), is(equalTo(value2)));
}
+ @Test
+ void testReplaceAll() {
Review Comment:
IMO it is always beneficial to see in the test code the specific properties
that are being tested/asserted/verified.
If you think it's too costly to split the method to 3 methods, at least each
of the test cases can be put into braces to make it more visible that it forms
a separate test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
