sashapolo commented on code in PR #1213:
URL: https://github.com/apache/ignite-3/pull/1213#discussion_r997216660


##########
modules/storage-page-memory/src/test/java/org/apache/ignite/internal/storage/pagememory/index/AbstractPageMemoryHashIndexStorageTest.java:
##########
@@ -40,6 +42,8 @@
 abstract class AbstractPageMemoryHashIndexStorageTest extends 
AbstractHashIndexStorageTest {
     protected BasePageMemoryStorageEngineConfiguration<?, ?> baseEngineConfig;
 
+    protected Random random = ThreadLocalRandom.current();

Review Comment:
   1. Should be `private` and `final`
   2. I don't think this is a correct way to use `ThreadLocalRandom` (tests may 
run in parallel, theoretically), plain `Random` should suffice



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to