AMashenkov commented on code in PR #1191:
URL: https://github.com/apache/ignite-3/pull/1191#discussion_r1003124169
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvTableStorage.java:
##########
@@ -118,6 +119,17 @@ default IndexStorage getOrCreateIndex(int partitionId,
UUID indexId) {
*/
HashIndexStorage getOrCreateHashIndex(int partitionId, UUID indexId);
+ /**
+ * Returns an already created Hash Index with the given descriptor or
creates a new one if it does not exist.
+ *
+ * @param partitionId Partition ID for which this index has been
configured.
+ * @param descriptor A description of the index to be created.
+ * @return Hash Index storage.
+ * @throws StorageException If the given partition does not exist, or the
given index does not exist or is not configured as a
+ * hash index.
+ */
+ HashIndexStorage getOrCreateHashIndex(int partitionId, HashIndexDescriptor
descriptor);
Review Comment:
@ibessonov maybe more general method will be better
`public IndexStorage getIndexStorage(int partId, UUID indexId)`
Seems, in some cases we don't know the type of index, e.g. index scan
request contains only indexId.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
