kgusakov commented on code in PR #1234:
URL: https://github.com/apache/ignite-3/pull/1234#discussion_r1009310645
##########
modules/metrics/src/main/java/org/apache/ignite/internal/metrics/MetricManager.java:
##########
@@ -178,15 +192,19 @@ public static Map<String, MetricExporter> loadExporters()
{
*/
public void disable(MetricSource src) {
registry.disable(src);
+
+ enabledMetricExporters.values().forEach(e ->
e.removeMetricSet(src.name()));
}
/**
- * Disable metric source by name. See {@link
MetricRegistry#disable(String)}.
+ * Disable metric set by name. See {@link MetricRegistry#disable(String)}.
*
- * @param srcName Source name.
+ * @param metricSetName Metric set name.
*/
- public void disable(final String srcName) {
- registry.disable(srcName);
+ public void disable(final String metricSetName) {
Review Comment:
Renamed by mistake. Fixed, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
