isapego commented on code in PR #1287: URL: https://github.com/apache/ignite-3/pull/1287#discussion_r1010105099
########## modules/platforms/cpp/ignite/client/table/record_view.h: ########## @@ -0,0 +1,493 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include "ignite/client/table/ignite_tuple.h" +#include "ignite/client/transaction/transaction.h" + +#include "ignite/common/config.h" +#include "ignite/common/ignite_result.h" + +#include <memory> +#include <utility> +#include <vector> +#include <type_traits> + +namespace ignite { + +class table; + +namespace detail { +class table_impl; +} + +/** + * Record view interface provides methods to access table records. + */ +template<typename T> +class record_view { +public: + typedef typename std::decay<T>::type value_type; + + // Deleted + record_view(const record_view &) = delete; + record_view &operator=(const record_view &) = delete; + + // Default + record_view() = default; + ~record_view() = default; + record_view(record_view &&) noexcept = default; + record_view &operator=(record_view &&) noexcept = default; +}; + +/** + * Record view interface provides methods to access table records. + */ +template<> +class record_view<ignite_tuple> { + friend class table; +public: + typedef ignite_tuple value_type; + + // Deleted + record_view(const record_view &) = delete; + record_view &operator=(const record_view &) = delete; + + // Default + record_view() = default; + ~record_view() = default; + record_view(record_view &&) noexcept = default; + record_view &operator=(record_view &&) noexcept = default; + + /** + * Gets a record by key asynchronously. + * + * @param tx Optional transaction. If nullptr implicit transaction for this + * single operation is used. + * @param key Key. + * @param callback Callback which is called on success with value if it + * exists and @c std::nullopt otherwise + */ + IGNITE_API void get_async(transaction* tx, const value_type& key, ignite_callback<std::optional<value_type>> callback); + + /** + * Gets a record by key. + * + * @param tx Optional transaction. If nullptr implicit transaction for this + * single operation is used. + * @param key Key. + * @return Value if exists and @c std::nullopt otherwise. + */ + [[nodiscard]] IGNITE_API std::optional<value_type> get(transaction* tx, const value_type& key) { + return sync<std::optional<value_type>>([this, tx, &key] (auto callback) { + get_async(tx, key, std::move(callback)); + }); + } + + /** + * Gets multiple records by keys asynchronously. + * + * @param tx Optional transaction. If nullptr implicit transaction for this + * single operation is used. + * @param keys Keys. + * @param callback Callback that called on operation completion. Called with + * resulting records with all columns filled from the table. The order of + * elements is guaranteed to be the same as the order of keys. If a record + * does not exist, the resulting element of the corresponding order is + * @c std::nullopt. + */ + IGNITE_API void get_all_async(transaction* tx, std::vector<value_type> keys, + ignite_callback<std::vector<std::optional<value_type>>> callback); + + /** + * Gets multiple records by keys. + * + * @param tx Optional transaction. If nullptr implicit transaction for this + * single operation is used. + * @param keys Keys. + * @return Resulting records with all columns filled from the table. + * The order of elements is guaranteed to be the same as the order of + * keys. If a record does not exist, the resulting element of the + * corresponding order is @c std::nullopt. + */ + [[nodiscard]] IGNITE_API std::vector<std::optional<value_type>> get_all(transaction* tx, std::vector<value_type> keys) { + return sync<std::vector<std::optional<value_type>>>([this, tx, keys = std::move(keys)] (auto callback) mutable { + get_all_async(tx, std::move(keys), std::move(callback)); + }); + } + + /** + * Inserts a record into the table if does not exist or replaces the existed one. + * + * @param tx Optional transaction. If nullptr implicit transaction for this + * single operation is used. + * @param record A record to insert into the table. The record cannot be @c nullptr. + * @param callback Callback. + */ + IGNITE_API void upsert_async(transaction* tx, const value_type& record, ignite_callback<void> callback); + + /** + * Inserts a record into the table if does not exist or replaces the existed one. Review Comment: Agree. Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
