rpuch commented on code in PR #1280:
URL: https://github.com/apache/ignite-3/pull/1280#discussion_r1010549523
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/snapshot/outgoing/SnapshotAwarePartitionDataStorage.java:
##########
@@ -123,11 +127,21 @@ private void handleSnapshotInterference(RowId rowId) {
@Override
public void close() throws Exception {
- // TODO: IGNITE-17935 - terminate all snapshots of this partition
considering correct locking to do it consistently
+ cleanupSnapshots();
partitionStorage.close();
}
+ private void cleanupSnapshots() {
+ PartitionSnapshots partitionSnapshots = getPartitionSnapshots();
+
+ try (AutoLockup ignored = partitionSnapshots.acquireReadLock()) {
Review Comment:
What name do you suggest? I called it 'ignored', because it is ignored and
mandated by the compiler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
