sergeyuttsel commented on code in PR #1282:
URL: https://github.com/apache/ignite-3/pull/1282#discussion_r1011688747
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -969,18 +971,28 @@ public void stop() {
*/
private void cleanUpTablesResources(Map<UUID, TableImpl> tables) {
for (TableImpl table : tables.values()) {
- try {
- for (int p = 0; p < table.internalTable().partitions(); p++) {
- TablePartitionId replicationGroupId = new
TablePartitionId(table.tableId(), p);
+ for (int p = 0; p < table.internalTable().partitions(); p++) {
+ TablePartitionId replicationGroupId = new
TablePartitionId(table.tableId(), p);
+ try {
raftMgr.stopRaftGroup(replicationGroupId);
+ } catch (Exception e) {
+ LOG.info("Unable to stop the raft group [tableName={},
partition={}]", e, table.name(), p);
+ }
+ try {
replicaMgr.stopReplica(replicationGroupId);
+ } catch (Exception e) {
+ LOG.info("Unable to stop the replica [tableName={},
partition={}]", e, table.name(), p);
}
+ }
- table.internalTable().storage().stop();
- table.internalTable().txStateStorage().stop();
- table.internalTable().close();
+ try {
+ IgniteUtils.closeAll(
+ Stream.of(table.internalTable().storage(),
+ table.internalTable().txStateStorage(),
+ table.internalTable())
+ );
} catch (Exception e) {
LOG.info("Unable to stop table [name={}]", e, table.name());
Review Comment:
Fixed.
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -969,18 +971,28 @@ public void stop() {
*/
private void cleanUpTablesResources(Map<UUID, TableImpl> tables) {
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
