ibessonov commented on code in PR #1354:
URL: https://github.com/apache/ignite-3/pull/1354#discussion_r1026122117
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/message/MessageListener.java:
##########
@@ -27,8 +27,8 @@ public interface MessageListener {
/**
* OnMessage.
*
- * @param nodeId Sender node ID.
+ * @param nodeName Sender node consistent ID.
* @param msg Message.
Review Comment:
```suggestion
* @param msg Message.
```
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/Outbox.java:
##########
@@ -95,15 +95,15 @@ public long exchangeId() {
/**
* Callback method.
*
- * @param nodeId Target ID.
+ * @param nodeName Target consistent ID.
Review Comment:
```suggestion
* @param nodeName Target consistent ID.
```
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/metadata/RemoteException.java:
##########
@@ -34,22 +34,22 @@ public class RemoteException extends RuntimeException {
* Constructor.
*
* @param cause Cause.
- * @param nodeId Node ID.
+ * @param nodeName Node consistent ID.
Review Comment:
```suggestion
* @param nodeName Node consistent ID.
```
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/metadata/RemoteException.java:
##########
@@ -34,22 +34,22 @@ public class RemoteException extends RuntimeException {
* Constructor.
*
* @param cause Cause.
- * @param nodeId Node ID.
+ * @param nodeName Node consistent ID.
Review Comment:
Please format other lines too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
