rpuch commented on code in PR #1405:
URL: https://github.com/apache/ignite-3/pull/1405#discussion_r1044189846
##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/BaseMvStoragesTest.java:
##########
@@ -152,7 +152,7 @@ protected static TestValue value(BinaryRow binaryRow) {
return new IgniteBiTuple<>(key(binaryRow), value(binaryRow));
}
- protected static List<IgniteBiTuple<TestKey, TestValue>>
toList(Cursor<ReadResult> cursor) throws Exception {
+ protected static List<IgniteBiTuple<TestKey, TestValue>>
drainToList(Cursor<ReadResult> cursor) throws Exception {
Review Comment:
Removed the `throws` declaration.
I renamed the method so that we can statically import `Collectors.toList`.
There is `BlockingQueue.drainTo()` that drains the queue to a collection.
`drainToList` follows the same logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]