tkalkirill commented on code in PR #1461: URL: https://github.com/apache/ignite-3/pull/1461#discussion_r1058242275
########## modules/runner/src/integrationTest/java/org/apache/ignite/internal/raftsnapshot/ItTableRaftSnapshotsTest.java: ########## @@ -0,0 +1,637 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.raftsnapshot; + +import static java.util.stream.Collectors.toList; +import static org.apache.ignite.internal.testframework.IgniteTestUtils.hasCause; +import static org.apache.ignite.internal.testframework.IgniteTestUtils.waitForCondition; +import static org.apache.ignite.internal.testframework.matchers.CompletableFutureMatcher.willSucceedIn; +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.Matchers.equalTo; +import static org.hamcrest.Matchers.is; +import static org.junit.jupiter.api.Assertions.assertTrue; +import static org.junit.jupiter.api.Assertions.fail; + +import java.nio.file.Path; +import java.util.ArrayList; +import java.util.List; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.CountDownLatch; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.concurrent.atomic.AtomicReference; +import java.util.function.BooleanSupplier; +import java.util.function.Consumer; +import java.util.function.Function; +import java.util.function.Supplier; +import java.util.logging.LogRecord; +import java.util.logging.Logger; +import java.util.stream.IntStream; +import org.apache.calcite.sql.validate.SqlValidatorException; +import org.apache.ignite.internal.Cluster; +import org.apache.ignite.internal.Cluster.NodeKnockout; +import org.apache.ignite.internal.app.IgniteImpl; +import org.apache.ignite.internal.logger.IgniteLogger; +import org.apache.ignite.internal.logger.Loggers; +import org.apache.ignite.internal.raft.RaftNodeId; +import org.apache.ignite.internal.replicator.exception.ReplicationTimeoutException; +import org.apache.ignite.internal.storage.pagememory.PersistentPageMemoryStorageEngine; +import org.apache.ignite.internal.storage.pagememory.VolatilePageMemoryStorageEngine; +import org.apache.ignite.internal.storage.rocksdb.RocksDbStorageEngine; +import org.apache.ignite.internal.table.distributed.replicator.TablePartitionId; +import org.apache.ignite.internal.testframework.IgniteTestUtils; +import org.apache.ignite.internal.testframework.WorkDirectory; +import org.apache.ignite.internal.testframework.WorkDirectoryExtension; +import org.apache.ignite.internal.testframework.jul.NoOpHandler; +import org.apache.ignite.lang.IgniteBiTuple; +import org.apache.ignite.lang.IgniteInternalCheckedException; +import org.apache.ignite.lang.IgniteInternalException; +import org.apache.ignite.raft.jraft.RaftGroupService; +import org.apache.ignite.raft.jraft.Status; +import org.apache.ignite.raft.jraft.core.NodeImpl; +import org.apache.ignite.raft.jraft.core.Replicator; +import org.apache.ignite.raft.jraft.entity.PeerId; +import org.apache.ignite.raft.jraft.error.RaftError; +import org.apache.ignite.sql.ResultSet; +import org.apache.ignite.sql.Session; +import org.apache.ignite.sql.SqlRow; +import org.apache.ignite.tx.Transaction; +import org.jetbrains.annotations.Nullable; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Disabled; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.TestInfo; +import org.junit.jupiter.api.Timeout; +import org.junit.jupiter.api.extension.ExtendWith; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.ValueSource; + +/** + * Tests how RAFT snapshots installation works for table partitions. + */ +@SuppressWarnings("resource") +@ExtendWith(WorkDirectoryExtension.class) +@Timeout(60) +// TODO: IGNITE-18465- extend AbstractClusterIntegrationTest +class ItTableRaftSnapshotsTest { + private static final IgniteLogger LOG = Loggers.forClass(ItTableRaftSnapshotsTest.class); + + /** + * Nodes bootstrap configuration pattern. + * + * <p>rpcInstallSnapshotTimeout is changed to 10 seconds so that sporadic snapshot installation failures still + * allow tests pass thanks to retries. + */ + private static final String NODE_BOOTSTRAP_CFG = "{\n" + + " \"network\": {\n" + + " \"port\":{},\n" + + " \"nodeFinder\":{\n" + + " \"netClusterNodes\": [ {} ]\n" + + " }\n" + + " },\n" + + " \"raft\": {" + + " \"rpcInstallSnapshotTimeout\": 10000" + + " }" + + "}"; + + /** + * Marker that instructs to create a table with the default storage engine. Used in tests that are indifferent + * to a storage engine used. + */ + private static final String DEFAULT_STORAGE_ENGINE = "<default>"; + + /** + * {@link NodeKnockout} that is used by tests that are indifferent for the knockout strategy being used. + */ + private static final NodeKnockout DEFAULT_KNOCKOUT = NodeKnockout.PARTITION_NETWORK; + + @WorkDirectory + private Path workDir; + + private Cluster cluster; + + @BeforeEach + void createCluster(TestInfo testInfo) { + cluster = new Cluster(testInfo, workDir, NODE_BOOTSTRAP_CFG); + } + + @AfterEach + void shutdownCluster() { + cluster.shutdown(); + } + + private void doInSession(int nodeIndex, Consumer<Session> action) { Review Comment: I think it will be useful to move methods `doInSession` and `executeUpdate` and `query` to `Cluster`. ########## modules/runner/src/integrationTest/java/org/apache/ignite/internal/raftsnapshot/ItTableRaftSnapshotsTest.java: ########## @@ -0,0 +1,637 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.raftsnapshot; + +import static java.util.stream.Collectors.toList; +import static org.apache.ignite.internal.testframework.IgniteTestUtils.hasCause; +import static org.apache.ignite.internal.testframework.IgniteTestUtils.waitForCondition; +import static org.apache.ignite.internal.testframework.matchers.CompletableFutureMatcher.willSucceedIn; +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.Matchers.equalTo; +import static org.hamcrest.Matchers.is; +import static org.junit.jupiter.api.Assertions.assertTrue; +import static org.junit.jupiter.api.Assertions.fail; + +import java.nio.file.Path; +import java.util.ArrayList; +import java.util.List; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.CountDownLatch; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.concurrent.atomic.AtomicReference; +import java.util.function.BooleanSupplier; +import java.util.function.Consumer; +import java.util.function.Function; +import java.util.function.Supplier; +import java.util.logging.LogRecord; +import java.util.logging.Logger; +import java.util.stream.IntStream; +import org.apache.calcite.sql.validate.SqlValidatorException; +import org.apache.ignite.internal.Cluster; +import org.apache.ignite.internal.Cluster.NodeKnockout; +import org.apache.ignite.internal.app.IgniteImpl; +import org.apache.ignite.internal.logger.IgniteLogger; +import org.apache.ignite.internal.logger.Loggers; +import org.apache.ignite.internal.raft.RaftNodeId; +import org.apache.ignite.internal.replicator.exception.ReplicationTimeoutException; +import org.apache.ignite.internal.storage.pagememory.PersistentPageMemoryStorageEngine; +import org.apache.ignite.internal.storage.pagememory.VolatilePageMemoryStorageEngine; +import org.apache.ignite.internal.storage.rocksdb.RocksDbStorageEngine; +import org.apache.ignite.internal.table.distributed.replicator.TablePartitionId; +import org.apache.ignite.internal.testframework.IgniteTestUtils; +import org.apache.ignite.internal.testframework.WorkDirectory; +import org.apache.ignite.internal.testframework.WorkDirectoryExtension; +import org.apache.ignite.internal.testframework.jul.NoOpHandler; +import org.apache.ignite.lang.IgniteBiTuple; +import org.apache.ignite.lang.IgniteInternalCheckedException; +import org.apache.ignite.lang.IgniteInternalException; +import org.apache.ignite.raft.jraft.RaftGroupService; +import org.apache.ignite.raft.jraft.Status; +import org.apache.ignite.raft.jraft.core.NodeImpl; +import org.apache.ignite.raft.jraft.core.Replicator; +import org.apache.ignite.raft.jraft.entity.PeerId; +import org.apache.ignite.raft.jraft.error.RaftError; +import org.apache.ignite.sql.ResultSet; +import org.apache.ignite.sql.Session; +import org.apache.ignite.sql.SqlRow; +import org.apache.ignite.tx.Transaction; +import org.jetbrains.annotations.Nullable; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Disabled; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.TestInfo; +import org.junit.jupiter.api.Timeout; +import org.junit.jupiter.api.extension.ExtendWith; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.ValueSource; + +/** + * Tests how RAFT snapshots installation works for table partitions. + */ +@SuppressWarnings("resource") +@ExtendWith(WorkDirectoryExtension.class) +@Timeout(60) +// TODO: IGNITE-18465- extend AbstractClusterIntegrationTest +class ItTableRaftSnapshotsTest { + private static final IgniteLogger LOG = Loggers.forClass(ItTableRaftSnapshotsTest.class); + + /** + * Nodes bootstrap configuration pattern. + * + * <p>rpcInstallSnapshotTimeout is changed to 10 seconds so that sporadic snapshot installation failures still + * allow tests pass thanks to retries. + */ + private static final String NODE_BOOTSTRAP_CFG = "{\n" + + " \"network\": {\n" + + " \"port\":{},\n" + + " \"nodeFinder\":{\n" + + " \"netClusterNodes\": [ {} ]\n" + + " }\n" + + " },\n" + + " \"raft\": {" + + " \"rpcInstallSnapshotTimeout\": 10000" + + " }" + + "}"; + + /** + * Marker that instructs to create a table with the default storage engine. Used in tests that are indifferent + * to a storage engine used. + */ + private static final String DEFAULT_STORAGE_ENGINE = "<default>"; + + /** + * {@link NodeKnockout} that is used by tests that are indifferent for the knockout strategy being used. + */ + private static final NodeKnockout DEFAULT_KNOCKOUT = NodeKnockout.PARTITION_NETWORK; + + @WorkDirectory + private Path workDir; + + private Cluster cluster; + + @BeforeEach + void createCluster(TestInfo testInfo) { + cluster = new Cluster(testInfo, workDir, NODE_BOOTSTRAP_CFG); + } + + @AfterEach + void shutdownCluster() { + cluster.shutdown(); + } + + private void doInSession(int nodeIndex, Consumer<Session> action) { Review Comment: I think it will be useful to move methods `doInSession`, `executeUpdate` and `query` to `Cluster`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
