korlov42 commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1070908480
########## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItImplicitCastsTest.java: ########## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine; + +import java.util.stream.Stream; +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.sql.type.SqlTypeName; +import org.apache.ignite.internal.sql.engine.type.IgniteTypeFactory; +import org.apache.ignite.tx.Transaction; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.MethodSource; + +/** + * Implicit casts are added where it is necessary to do so. + */ +public class ItImplicitCastsTest extends AbstractBasicIntegrationTest { + + @ParameterizedTest + @MethodSource("columnPairs") + public void testFilter(ColumnPair columnPair) { + prepareTables(columnPair); + + try { + assertQuery("SELECT T11.c2 FROM T11 WHERE T11.c2 > 1.0").check(); + } finally { + sql("DROP TABLE T11"); + sql("DROP TABLE T12"); + } + } + + @ParameterizedTest + @MethodSource("columnPairs") + public void testMergeSort(ColumnPair columnPair) { + prepareTables(columnPair); + + try { + assertQuery("SELECT T11.c2, T12.c2 FROM T11, T12 WHERE T11.c2 = T12.c2").check(); + + assertQuery("SELECT T11.c2, T12.c2 FROM T11, T12 WHERE T11.c2 IS NOT DISTINCT FROM T12.c2").check(); + } finally { + sql("DROP TABLE T11"); Review Comment: let's move all cleanup stuff to outside of the method (to `@AfterEach`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
