korlov42 commented on code in PR #1479:
URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1073145119
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/MvPartitionStorage.java:
##########
@@ -151,7 +151,7 @@ public interface MvPartitionStorage extends
ManuallyCloseable {
* @throws TxIdMismatchException If there's another pending update
associated with different transaction id.
* @throws StorageException If failed to write data to the storage.
*/
- @Nullable BinaryRow addWrite(RowId rowId, @Nullable BinaryRow row, UUID
txId, UUID commitTableId, int commitPartitionId)
+ @Nullable TableRow addWrite(RowId rowId, @Nullable TableRow row, UUID
txId, UUID commitTableId, int commitPartitionId)
Review Comment:
> The storage engine does not have to store the schema version together with
every row too. It is sufficient to remember the transaction timestamp since
which a given table schema version is in effect.
That is not how it's working right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
