nizhikov commented on code in PR #10314:
URL: https://github.com/apache/ignite/pull/10314#discussion_r1081036626


##########
modules/core/src/main/java/org/apache/ignite/internal/pagemem/wal/record/ConsistentCutFinishRecord.java:
##########
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.pagemem.wal.record;
+
+import java.util.Set;
+import java.util.UUID;
+import 
org.apache.ignite.internal.processors.cache.persistence.tree.io.CacheVersionIO;
+import org.apache.ignite.internal.processors.cache.version.GridCacheVersion;
+import org.apache.ignite.internal.util.tostring.GridToStringInclude;
+import org.apache.ignite.internal.util.typedef.internal.S;
+
+/**
+ * This record is written to WAL after Consistent Cut finished on a baseline 
node.
+ * <p>
+ * During recovery node must apply:
+ * 1. Transactions committed before {@link ConsistentCutStartRecord} except 
those contained in {@link #excluded()}.
+ * 2. Transactions committed between {@link ConsistentCutStartRecord} and 
{@link ConsistentCutFinishRecord}
+ *    and contained in {@link #included()}.
+ */
+public class ConsistentCutFinishRecord extends WALRecord {
+    /** Consistent Cut ID. */
+    @GridToStringInclude
+    private final UUID id;
+
+    /**
+     * Set of transactions committed between {@link ConsistentCutStartRecord} 
and {@link ConsistentCutFinishRecord}

Review Comment:
   This comment must be updated.



##########
modules/core/src/main/java/org/apache/ignite/internal/pagemem/wal/record/ConsistentCutFinishRecord.java:
##########
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.pagemem.wal.record;
+
+import java.util.Set;
+import java.util.UUID;
+import 
org.apache.ignite.internal.processors.cache.persistence.tree.io.CacheVersionIO;
+import org.apache.ignite.internal.processors.cache.version.GridCacheVersion;
+import org.apache.ignite.internal.util.tostring.GridToStringInclude;
+import org.apache.ignite.internal.util.typedef.internal.S;
+
+/**
+ * This record is written to WAL after Consistent Cut finished on a baseline 
node.
+ * <p>
+ * During recovery node must apply:
+ * 1. Transactions committed before {@link ConsistentCutStartRecord} except 
those contained in {@link #excluded()}.
+ * 2. Transactions committed between {@link ConsistentCutStartRecord} and 
{@link ConsistentCutFinishRecord}
+ *    and contained in {@link #included()}.
+ */
+public class ConsistentCutFinishRecord extends WALRecord {
+    /** Consistent Cut ID. */
+    @GridToStringInclude
+    private final UUID id;
+
+    /**
+     * Set of transactions committed between {@link ConsistentCutStartRecord} 
and {@link ConsistentCutFinishRecord}
+     * to include to the BEFORE side of Consistent Cut.
+     */
+    @GridToStringInclude
+    private final Set<GridCacheVersion> included;
+
+    /**
+     * Set of transactions committed before {@link ConsistentCutStartRecord} 
to exclude from the AFTER side of Consistent Cut.

Review Comment:
   This comment must be updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to