tkalkirill commented on code in PR #1556:
URL: https://github.com/apache/ignite-3/pull/1556#discussion_r1083918501
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/snapshot/incoming/IncomingSnapshotCopier.java:
##########
@@ -186,32 +186,13 @@ public SnapshotReader getReader() {
/**
* Prepares the {@link MvPartitionStorage} for a full rebalance.
- *
- * <p>Recreates {@link MvPartitionStorage} and sets the last applied index
to {@link TableManager#FULL_RABALANCING_STARTED} so that
- * when the node is restarted, we can understand that the full rebalance
has not completed, and we need to clean up the storage from
- * garbage.
*/
- private CompletableFuture<?>
prepareMvPartitionStorageForRebalance(Executor executor) {
+ private CompletableFuture<?> prepareMvPartitionStorageForRebalance() {
if (canceled) {
return completedFuture(null);
}
- return
partitionSnapshotStorage.partition().reCreateMvPartitionStorage()
- .thenComposeAsync(mvPartitionStorage -> {
- if (canceled) {
- return completedFuture(null);
- }
-
- mvPartitionStorage.runConsistently(() -> {
-
mvPartitionStorage.lastApplied(FULL_RABALANCING_STARTED, 0);
-
- return null;
- });
-
- LOG.info("Copier prepared multi-versioned storage for the
partition [partId={}, tableId={}]", partId(), tableId());
-
- return completedFuture(null);
- }, executor);
+ return
partitionSnapshotStorage.partition().reCreateMvPartitionStorage();
Review Comment:
This code will be removed soon, left TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
