rpuch commented on code in PR #1559:
URL: https://github.com/apache/ignite-3/pull/1559#discussion_r1084947146
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/VolatilePageMemoryMvPartitionStorage.java:
##########
@@ -149,17 +153,32 @@ public void lastAppliedOnRebalance(long lastAppliedIndex,
long lastAppliedTerm)
}
/**
- * Destroys internal structures backing this partition.
+ * Destroys internal structures (including indices) backing this partition.
*
- * @return future that completes when the destruction completes.
+ * @param removeIndexDescriptors Whether indices should be completely
removed, not just their contents destroyed.
*/
- public CompletableFuture<Void> destroyStructures() {
- // TODO: IGNITE-18531 - destroy indices.
+ public void destroyStructures(boolean removeIndexDescriptors) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
