isapego commented on code in PR #1594:
URL: https://github.com/apache/ignite-3/pull/1594#discussion_r1089062418
##########
modules/platforms/cpp/ignite/schema/types.h:
##########
@@ -25,22 +25,23 @@
namespace ignite {
-/** C++ version of java int. Used as column number, etc. */
-using IntT = int32_t;
+/** C++ version of java int. Used as a column number, etc. */
+using number_t = int32_t;
/** Data size for columns and entire rows too. */
-using SizeT = uint32_t;
+using data_size_t = uint32_t;
/** Non-existent column/element number. */
-static constexpr IntT NO_NUM = -1;
+static constexpr number_t NOT_NUM = -1;
/** Binary value for a potentially nullable column. */
-using element_view = std::optional<bytes_view>;
+using value_view = std::optional<bytes_view>;
/** A set of binary values for a whole or partial row. */
-using tuple_view = std::vector<element_view>;
+using tuple_view = std::vector<value_view>;
Review Comment:
Update: the cause of this is leakage of `schema` headers in clients public
headers due to changes in `client/sql/column_metadata.h`. Those were a clients
private types before and now they are public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
