korlov42 commented on code in PR #1590:
URL: https://github.com/apache/ignite-3/pull/1590#discussion_r1090567260
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/index/ItIndexManagerTest.java:
##########
@@ -71,7 +71,7 @@ public void eventsAreFiredWhenIndexesCreatedAndDropped() {
CompletableFuture<IndexEventParameters> indexCreatedFuture =
registerListener(indexManager, IndexEvent.CREATE);
indexManager.createIndexAsync("PUBLIC", "INAME", "TNAME", true,
tableIndexChange ->
-
tableIndexChange.convert(HashIndexChange.class).changeColumnNames("C3",
"C2")).join();
+
tableIndexChange.convert(HashIndexChange.class).changeColumnNames("C3",
"C2")).get();
Review Comment:
agree with @ygerzhedovich. It's better to wait for reasonable amount of time
in the test itself then wait forever until the whole suite will be killed by
TC's watchdog after an hour of awaiting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]