rpuch commented on code in PR #1597:
URL: https://github.com/apache/ignite-3/pull/1597#discussion_r1090599396
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -332,7 +333,8 @@ public class IgniteImpl implements Ignite {
clusterSvc,
raftMgr,
clusterStateStorage,
- logicalTopology
+ logicalTopology,
+
nodeCfgMgr.configurationRegistry().getConfiguration(ClusterManagementConfiguration.KEY)
Review Comment:
We don't, but we have
```
public ConfigurationRegistry nodeConfiguration() {
return nodeCfgMgr.configurationRegistry();
}
```
in this class. At the same time, it seems awkward to use a public method in
our own constructor, this seems a bit fragile.
So I just extracted 2 local variables in the constructor (one for node
config registry, another for cluster config registry).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
