korlov42 commented on code in PR #1501:
URL: https://github.com/apache/ignite-3/pull/1501#discussion_r1090880977
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/IgniteTableImpl.java:
##########
@@ -480,10 +482,12 @@ private <RowT> ModifyRow deleteTuple(RowT row,
ExecutionContext<RowT> ectx) {
return new ModifyRow(new Row(schemaDescriptor, rowAssembler.build()),
Operation.DELETE_ROW);
}
- private ColocationGroup partitionedGroup() {
- List<List<String>> assignments = table.assignments().stream()
- .map(Collections::singletonList)
- .collect(Collectors.toList());
+ private ColocationGroup partitionedGroup(boolean collectLeaderTerms) {
+ Stream<NodeWithTerm> assignmentsStream = collectLeaderTerms
Review Comment:
why don't use `leaderAssignmentsWithTerm` for both RW and RO cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
