tkalkirill commented on code in PR #1599:
URL: https://github.com/apache/ignite-3/pull/1599#discussion_r1091781638
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -416,12 +416,6 @@ public boolean onSnapshotLoad(Path path) {
@Override
public void onShutdown() {
- // TODO: IGNITE-17958 - probably, we should not close the storage here
as PartitionListener did not create the storage.
- try {
- storage.close();
Review Comment:
Storages will be closed when the `TableStorage` stops.
And are destroyed, on evict of partition or destruction of the table.
Found tests:
-
org.apache.ignite.internal.table.distributed.TableManagerTest#endTableManagerStopTest
- org.apache.ignite.internal.table.distributed.TableManagerTest#testDropTable
- I don’t even know if testing is needed to evict a partition, it will be
possible to add it during implementation
[IGNITE-18160](https://issues.apache.org/jira/browse/IGNITE-18160,)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
