ygerzhedovich commented on code in PR #1590:
URL: https://github.com/apache/ignite-3/pull/1590#discussion_r1093141727
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/util/CompositeSubscriptionTest.java:
##########
@@ -157,28 +157,27 @@ private void doPublishSubscribe(
lsnr.reset(requested);
- CompletableFuture.runAsync(() -> compPublisher.subscribe(new
Subscriber<>() {
- @Override
- public void onSubscribe(Subscription subscription) {
- subscriptionRef.set(subscription);
- }
-
- @Override
- public void onNext(Integer item) {
- lsnr.onNext(item);
- }
-
- @Override
- public void onError(Throwable t) {
- assert false;
- }
-
- @Override
- public void onComplete() {
- lsnr.onComplete();
- }
- })
- ).join();
+ compPublisher.subscribe(new Subscriber<>() {
Review Comment:
please return back runAsync here, it requeres for the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
