PakhomovAlexander commented on code in PR #1549:
URL: https://github.com/apache/ignite-3/pull/1549#discussion_r1105409421
##########
modules/rest-api/src/main/java/org/apache/ignite/internal/rest/api/cluster/NodeMetadataDto.java:
##########
@@ -26,9 +26,11 @@
/**
* REST representation of {@link NodeMetadata}.
*/
-@Schema(name = "NodeMetadata")
+@Schema(name = "NodeMetadata", description = "Node metadata information.")
public class NodeMetadataDto {
+ @Schema(description = "The host exposed to REST API.")
private final String restHost;
+ @Schema(description = "The port exposed to REST API.")
private final int httpPort;
private final int httpsPort;
Review Comment:
```suggestion
@Schema(description = "The HTTPS port exposed to REST API.")
private final int httpsPort;
```
##########
modules/rest-api/src/main/java/org/apache/ignite/internal/rest/api/cluster/NetworkAddressDto.java:
##########
@@ -26,12 +26,14 @@
/**
* REST representation of {@link NetworkAddress}.
*/
-@Schema(name = "NetworkAddress")
+@Schema(name = "NetworkAddress", description = "Node network address
information.")
public class NetworkAddressDto {
/** Host. */
+ @Schema(description = "Name of the host node is on.")
private final String host;
/** Port. */
+ @Schema(description = "Port hte node runs on.")
Review Comment:
```suggestion
@Schema(description = "Port the node runs on.")
```
##########
modules/rest-api/src/main/java/org/apache/ignite/internal/rest/api/cluster/NodeMetadataDto.java:
##########
@@ -26,9 +26,11 @@
/**
* REST representation of {@link NodeMetadata}.
*/
-@Schema(name = "NodeMetadata")
+@Schema(name = "NodeMetadata", description = "Node metadata information.")
public class NodeMetadataDto {
+ @Schema(description = "The host exposed to REST API.")
private final String restHost;
+ @Schema(description = "The port exposed to REST API.")
Review Comment:
```suggestion
@Schema(description = "The HTTP port exposed to REST API.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
